This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#346
PR Checklist
Description
March platform release deploys two firewalls:
Hub attached firewall connectivity_secure_firewalls_env
VNet attached firewall as a central DNS instance connectivity_private_dns_firewalls_env
This change adds to correct firewall as dns server of the newly created VNet.
See the linked issue
Does this introduce a breaking change
YES
NO
It will change the current DNS Setting of existing ASVM Subscriptions. In my opinion, this setting is correct.
Testing
Build a level0 to level3 landingzone based on the march release, then use the asvm to create a hub attached subscription.
In my modified scenario, my change worked fine.